fix NPE bug

This commit is contained in:
Looly 2021-06-28 23:22:20 +08:00
parent ffed1d32fd
commit 1472cdc440
4 changed files with 11 additions and 10 deletions

View File

@ -24,7 +24,8 @@
* 【core 】 修复SqlFormatter部分SQL空指针问题issue#I3XS44@Gitee
* 【core 】 修复DateRange计算问题issue#I3Y1US@Gitee
* 【core 】 修复BeanCopier中setFieldNameEditor失效问题pr#349@Gitee
* 【core 】 修复ArrayUtil.indexOfSub查找bugpr#349@Gitee
* 【core 】 修复ArrayUtil.indexOfSub查找bugissue#1683@Github
* 【core 】 修复Node的权重比较空指针问题issue#1681@Github
-------------------------------------------------------------------------------------------------------------

View File

@ -1,5 +1,7 @@
package cn.hutool.core.lang.tree;
import cn.hutool.core.comparator.CompareUtil;
import java.io.Serializable;
/**
@ -74,11 +76,11 @@ public interface Node<T> extends Comparable<Node<T>>, Serializable {
@SuppressWarnings({"unchecked", "rawtypes", "NullableProblems"})
@Override
default int compareTo(Node node) {
if(null == node){
return 1;
}
final Comparable weight = this.getWeight();
if (null != weight) {
final Comparable weightOther = node.getWeight();
return weight.compareTo(weightOther);
}
return 0;
return CompareUtil.compare(weight, weightOther);
}
}

View File

@ -12,5 +12,4 @@ public class TreeBuilderTest {
of.build();
of.append(new ArrayList<>());
}
}

View File

@ -28,7 +28,7 @@ public class TreeTest {
@Test
public void sampleTree() {
public void sampleTreeTest() {
List<Tree<String>> treeList = TreeUtil.build(nodeList, "0");
for (Tree<String> tree : treeList) {
Assert.assertNotNull(tree);
@ -43,7 +43,7 @@ public class TreeTest {
}
@Test
public void tree() {
public void treeTest() {
//配置
TreeNodeConfig treeNodeConfig = new TreeNodeConfig();
@ -66,5 +66,4 @@ public class TreeTest {
Assert.assertEquals(treeNodes.size(), 2);
}
}