From 612441615d24c46e29b790549e3b26f99564069d Mon Sep 17 00:00:00 2001 From: Looly Date: Mon, 13 Sep 2021 11:53:12 +0800 Subject: [PATCH] change method param --- CHANGELOG.md | 1 + .../src/main/java/cn/hutool/core/text/csv/CsvWriter.java | 5 ++--- .../test/java/cn/hutool/poi/excel/ExcelWriteTest.java | 9 +++++++++ 3 files changed, 12 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 973b7afdd..c595865f0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,7 @@ ### 🐣新特性 * 【core 】 CsvReadConfig增加trimField选项(issue#I49M0C@Gitee) * 【http 】 HttpBase增加clearHeaders方法(issue#I49P23@Gitee) +* 【core 】 CsvWriter的write和writeBeans参数改为Iterable(issue#I49O4S@Gitee) * ### 🐞Bug修复 * 【core 】 修复FuncKey函数无效问题 diff --git a/hutool-core/src/main/java/cn/hutool/core/text/csv/CsvWriter.java b/hutool-core/src/main/java/cn/hutool/core/text/csv/CsvWriter.java index 5dee35f74..c4ad4a630 100644 --- a/hutool-core/src/main/java/cn/hutool/core/text/csv/CsvWriter.java +++ b/hutool-core/src/main/java/cn/hutool/core/text/csv/CsvWriter.java @@ -20,7 +20,6 @@ import java.io.IOException; import java.io.Serializable; import java.io.Writer; import java.nio.charset.Charset; -import java.util.Collection; import java.util.List; import java.util.Map; @@ -199,7 +198,7 @@ public final class CsvWriter implements Closeable, Flushable, Serializable { * @return this * @throws IORuntimeException IO异常 */ - public CsvWriter write(Collection lines) throws IORuntimeException { + public CsvWriter write(Iterable lines) throws IORuntimeException { if (CollUtil.isNotEmpty(lines)) { for (Object values : lines) { appendLine(Convert.toStrArray(values)); @@ -236,7 +235,7 @@ public final class CsvWriter implements Closeable, Flushable, Serializable { * @param beans Bean集合 * @return this */ - public CsvWriter writeBeans(Collection beans) { + public CsvWriter writeBeans(Iterable beans) { if (CollUtil.isNotEmpty(beans)) { boolean isFirst = true; Map map; diff --git a/hutool-poi/src/test/java/cn/hutool/poi/excel/ExcelWriteTest.java b/hutool-poi/src/test/java/cn/hutool/poi/excel/ExcelWriteTest.java index ad8a702bb..3d9892e6f 100644 --- a/hutool-poi/src/test/java/cn/hutool/poi/excel/ExcelWriteTest.java +++ b/hutool-poi/src/test/java/cn/hutool/poi/excel/ExcelWriteTest.java @@ -761,4 +761,13 @@ public class ExcelWriteTest { writer.writeRow(row); writer.close(); } + + @Test + @Ignore + public void writeLongTest(){ + //https://gitee.com/dromara/hutool/issues/I49R6U + final ExcelWriter writer = ExcelUtil.getWriter("d:/test/long.xlsx"); + writer.write(ListUtil.of(1427545395336093698L)); + writer.close(); + } }