- Fix java.lang.NullPointerException

at com.wisemapping.util.Browser.isInUserAgentString(Browser.java:267)
      	at com.wisemapping.util.Browser.checkUserAgent(Browser.java:2 issue.
main
Paulo Gustavo Veiga 2012-09-19 19:24:30 -03:00
parent f8cb849597
commit 6555203a94
1 changed files with 154 additions and 149 deletions

View File

@ -57,164 +57,169 @@ package com.wisemapping.util;
* <a href="http://blogs.msdn.com/iemobile/archive/2006/08/03/Detecting_IE_Mobile.aspx">Detecting Internet Explorer Mobile's User-Agent on the server</a> * <a href="http://blogs.msdn.com/iemobile/archive/2006/08/03/Detecting_IE_Mobile.aspx">Detecting Internet Explorer Mobile's User-Agent on the server</a>
*/ */
import org.jetbrains.annotations.Nullable;
/** /**
* @author harald * @author harald
*
*/ */
public class UserAgent public class UserAgent {
{
private OperatingSystem operatingSystem = OperatingSystem.UNKNOWN; private OperatingSystem operatingSystem = OperatingSystem.UNKNOWN;
private Browser browser = Browser.UNKNOWN; private Browser browser = Browser.UNKNOWN;
private int id; private int id;
private String userAgentString; private String userAgentString;
public UserAgent(OperatingSystem operatingSystem, Browser browser) public UserAgent(OperatingSystem operatingSystem, Browser browser) {
{ this.operatingSystem = operatingSystem;
this.operatingSystem = operatingSystem; this.browser = browser;
this.browser = browser; this.id = ((operatingSystem.getId() << 16) + browser.getId());
this.id = (( operatingSystem.getId() << 16) + browser.getId()); }
}
public UserAgent(String userAgentString) public UserAgent(@Nullable String userAgentString) {
{ if (userAgentString != null) {
Browser browser = Browser.parseUserAgentString(userAgentString); Browser browser = Browser.parseUserAgentString(userAgentString);
OperatingSystem operatingSystem = OperatingSystem.UNKNOWN; OperatingSystem operatingSystem = OperatingSystem.UNKNOWN;
// BOTs don't have an interesting OS for us // BOTs don't have an interesting OS for us
if (browser != Browser.BOT) if (browser != Browser.BOT)
operatingSystem = OperatingSystem.parseUserAgentString(userAgentString); operatingSystem = OperatingSystem.parseUserAgentString(userAgentString);
this.operatingSystem = operatingSystem; this.operatingSystem = operatingSystem;
this.browser = browser; this.browser = browser;
this.id = (( operatingSystem.getId() << 16) + browser.getId()); this.id = ((operatingSystem.getId() << 16) + browser.getId());
this.userAgentString = userAgentString; this.userAgentString = userAgentString;
}
} else {
this.operatingSystem = OperatingSystem.UNKNOWN;
this.browser = Browser.UNKNOWN;
}
}
/** /**
* @param userAgentString * @param userAgentString
* @return UserAgent * @return UserAgent
*/ */
public static UserAgent parseUserAgentString(String userAgentString) { public static UserAgent parseUserAgentString(String userAgentString) {
return new UserAgent(userAgentString); return new UserAgent(userAgentString);
} }
/** /**
* Detects the detailed version information of the browser. Depends on the userAgent to be available. * Detects the detailed version information of the browser. Depends on the userAgent to be available.
* Use it only after using UserAgent(String) or UserAgent.parseUserAgent(String). * Use it only after using UserAgent(String) or UserAgent.parseUserAgent(String).
* Returns null if it can not detect the version information. * Returns null if it can not detect the version information.
* @return Version *
*/ * @return Version
public Version getBrowserVersion() { */
return this.browser.getVersion(this.userAgentString); public Version getBrowserVersion() {
} return this.browser.getVersion(this.userAgentString);
}
/** /**
* @return the system * @return the system
*/ */
public OperatingSystem getOperatingSystem() { public OperatingSystem getOperatingSystem() {
return operatingSystem; return operatingSystem;
} }
/** /**
* @return the browser * @return the browser
*/ */
public Browser getBrowser() { public Browser getBrowser() {
return browser; return browser;
} }
/** /**
* Returns an unique integer value of the operating system & browser combination * Returns an unique integer value of the operating system & browser combination
* @return the id *
*/ * @return the id
public int getId() { */
return id; public int getId() {
} return id;
}
/** /**
* Combined string representation of both enums * Combined string representation of both enums
*/ */
public String toString() { public String toString() {
return this.operatingSystem.toString() + "-" + this.browser.toString(); return this.operatingSystem.toString() + "-" + this.browser.toString();
} }
/** /**
* Returns UserAgent based on specified unique id * Returns UserAgent based on specified unique id
* @param id *
* @return * @param id
*/ * @return
public static UserAgent valueOf(int id) */
{ public static UserAgent valueOf(int id) {
OperatingSystem operatingSystem = OperatingSystem.valueOf((short) (id >> 16)); OperatingSystem operatingSystem = OperatingSystem.valueOf((short) (id >> 16));
Browser browser = Browser.valueOf( (short) (id & 0x0FFFF)); Browser browser = Browser.valueOf((short) (id & 0x0FFFF));
return new UserAgent(operatingSystem,browser); return new UserAgent(operatingSystem, browser);
} }
/** /**
* Returns UserAgent based on combined string representation * Returns UserAgent based on combined string representation
* @param name *
* @return * @param name
*/ * @return
public static UserAgent valueOf(String name) */
{ public static UserAgent valueOf(String name) {
if (name == null) if (name == null)
throw new NullPointerException("Name is null"); throw new NullPointerException("Name is null");
String[] elements = name.split("-"); String[] elements = name.split("-");
if (elements.length == 2) if (elements.length == 2) {
{ OperatingSystem operatingSystem = OperatingSystem.valueOf(elements[0]);
OperatingSystem operatingSystem = OperatingSystem.valueOf(elements[0]); Browser browser = Browser.valueOf(elements[1]);
Browser browser = Browser.valueOf(elements[1]); return new UserAgent(operatingSystem, browser);
return new UserAgent(operatingSystem,browser); }
}
throw new IllegalArgumentException( throw new IllegalArgumentException(
"Invalid string for userAgent " + name); "Invalid string for userAgent " + name);
} }
/* (non-Javadoc) /* (non-Javadoc)
* @see java.lang.Object#hashCode() * @see java.lang.Object#hashCode()
*/ */
@Override @Override
public int hashCode() { public int hashCode() {
final int prime = 31; final int prime = 31;
int result = 1; int result = 1;
result = prime * result + ((browser == null) ? 0 : browser.hashCode()); result = prime * result + ((browser == null) ? 0 : browser.hashCode());
result = prime * result + id; result = prime * result + id;
result = prime * result result = prime * result
+ ((operatingSystem == null) ? 0 : operatingSystem.hashCode()); + ((operatingSystem == null) ? 0 : operatingSystem.hashCode());
return result; return result;
} }
/* (non-Javadoc) /* (non-Javadoc)
* @see java.lang.Object#equals(java.lang.Object) * @see java.lang.Object#equals(java.lang.Object)
*/ */
@Override @Override
public boolean equals(Object obj) { public boolean equals(Object obj) {
if (this == obj) if (this == obj)
return true; return true;
if (obj == null) if (obj == null)
return false; return false;
if (getClass() != obj.getClass()) if (getClass() != obj.getClass())
return false; return false;
final UserAgent other = (UserAgent) obj; final UserAgent other = (UserAgent) obj;
if (browser == null) { if (browser == null) {
if (other.browser != null) if (other.browser != null)
return false; return false;
} else if (!browser.equals(other.browser)) } else if (!browser.equals(other.browser))
return false; return false;
if (id != other.id) if (id != other.id)
return false; return false;
if (operatingSystem == null) { if (operatingSystem == null) {
if (other.operatingSystem != null) if (other.operatingSystem != null)
return false; return false;
} else if (!operatingSystem.equals(other.operatingSystem)) } else if (!operatingSystem.equals(other.operatingSystem))
return false; return false;
return true; return true;
} }
} }